Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4480

Incorrect link to elastic.co in documentation

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.1
    • Fix Version/s: 1.1.2
    • Component/s: Documentation
    • Labels:
      None

      Description

      The link URL of the entry "Elasticsearch 2x (sink)" on the connector's documentation page https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/connectors/index.html is pointing to http://elastic.com but should point to http://elastic.co

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user smarthi opened a pull request:

          https://github.com/apache/flink/pull/2416

          FLINK-4480: Incorrect link to elastic.co in documentation

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [X] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/smarthi/flink FLINK-4480

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2416.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2416


          commit ea53aa1e715a8d862282cfbaff2243431455c0ae
          Author: smarthi <smarthi@apache.org>
          Date: 2016-08-24T22:07:23Z

          FLINK-4480: Incorrect link to elastic.co in documentation


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/2416 FLINK-4480 : Incorrect link to elastic.co in documentation Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [X] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/smarthi/flink FLINK-4480 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2416.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2416 commit ea53aa1e715a8d862282cfbaff2243431455c0ae Author: smarthi <smarthi@apache.org> Date: 2016-08-24T22:07:23Z FLINK-4480 : Incorrect link to elastic.co in documentation
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user smarthi commented on the issue:

          https://github.com/apache/flink/pull/2416

          1. Changed the ES2 version to 2.3.5
          2. Fixed broken ElasticsearchExample.java
          3. Removed use of Guava API.

          Show
          githubbot ASF GitHub Bot added a comment - Github user smarthi commented on the issue: https://github.com/apache/flink/pull/2416 1. Changed the ES2 version to 2.3.5 2. Fixed broken ElasticsearchExample.java 3. Removed use of Guava API.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/2416

          Hi @smarthi,
          Thank you for picking this up. The changes LGTM Also tested the 2.3.5 ES version bump.
          Good catches on the Guava and broken example also!

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2416 Hi @smarthi, Thank you for picking this up. The changes LGTM Also tested the 2.3.5 ES version bump. Good catches on the Guava and broken example also!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/2416

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2416 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2416

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2416 Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2416

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2416

            People

            • Assignee:
              smarthi Suneel Marthi
              Reporter:
              fhueske Fabian Hueske
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development