Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: flink-contrib
    • Labels:
      None
    • Flags:
      Patch

      Description

      The storm package path was changed in new version

      storm old version package:
      backtype.storm.*

      storm new version pachage:
      org.apache.storm.*

      shall we update flink/flink-storm code to new storm version?

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user liuyuzhong opened a pull request:

          https://github.com/apache/flink/pull/2439

          update storm verion to 1.0.0 in flink-storm and flink-storm-examples

          This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450

          Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype." to “org.apache.", and this change will work for all the storm which version higher than 1.0.0

          build successfully and run successfully in my test environment.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/liuyuzhong/flink master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2439.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2439


          commit eeb1fc284d6879404b05eab422ed898a9440cdb5
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-29T11:03:15Z

          #4450 update storm version to 1.0.0

          commit 055743ad65c6213e8fe8d422e929e795c3bad8f1
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:05:08Z

          #4450 update storm version to 1.0.0 in flink-storm-examples

          commit 409827d8e7ac69743b9c7f98774c001f6551457c
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:10:47Z

          #4450 reverse for uncorrect change submit pom.xml

          commit eebd8c534933fb2639dc248469ba56a2ed053cb7
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:12:00Z

          #4450 reverse for uncorrect change submit pom.xml

          commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-08-30T06:14:44Z

          Merge pull request #1 from liuyuzhong/4450

          #4450 update storm version to 1.0.0


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user liuyuzhong opened a pull request: https://github.com/apache/flink/pull/2439 update storm verion to 1.0.0 in flink-storm and flink-storm-examples This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450 Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype. " to “org.apache. ", and this change will work for all the storm which version higher than 1.0.0 build successfully and run successfully in my test environment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liuyuzhong/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2439 commit eeb1fc284d6879404b05eab422ed898a9440cdb5 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-29T11:03:15Z #4450 update storm version to 1.0.0 commit 055743ad65c6213e8fe8d422e929e795c3bad8f1 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:05:08Z #4450 update storm version to 1.0.0 in flink-storm-examples commit 409827d8e7ac69743b9c7f98774c001f6551457c Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:10:47Z #4450 reverse for uncorrect change submit pom.xml commit eebd8c534933fb2639dc248469ba56a2ed053cb7 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:12:00Z #4450 reverse for uncorrect change submit pom.xml commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf Author: liuyuzhong <darezhong@qq.com> Date: 2016-08-30T06:14:44Z Merge pull request #1 from liuyuzhong/4450 #4450 update storm version to 1.0.0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          mvn clean verify : ok

          test flink-storm-examples: ok
          bin/flink run WordCount-StormTopology.jar
          bin/flink run WordCount-BoltTokenizer.jar
          bin/flink run WordCount-SpoutSource.jar

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 mvn clean verify : ok test flink-storm-examples: ok bin/flink run WordCount-StormTopology.jar bin/flink run WordCount-BoltTokenizer.jar bin/flink run WordCount-SpoutSource.jar
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Jenkins run error:
          ```
          Running org.apache.flink.test.checkpointing.PartitionedStateCheckpointingITCase
          SUREFIRE-859: Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000000d8b00000, 100663296, 0) failed; error='Cannot allocate memory' (errno=12)
          #

          1. There is insufficient memory for the Java Runtime Environment to continue.
          2. Native memory allocation (mmap) failed to map 100663296 bytes for committing reserved memory.
          3. An error report file with more information is saved as:
          4. /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-tests/target/hs_err_pid9818.log
            Running org.apache.flink.test.checkpointing.WindowCheckpointingITCase
            ERROR: Maven JVM terminated unexpectedly with exit code 137
            Putting comment on the pull request
            Finished: FAILURE
            ```

          But I run it successfully in my environment, does it a Jenkins memory problem? Rerun it in Jenkins?

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Jenkins run error: ``` Running org.apache.flink.test.checkpointing.PartitionedStateCheckpointingITCase SUREFIRE-859 : Java HotSpot(TM) 64-Bit Server VM warning: INFO: os::commit_memory(0x00000000d8b00000, 100663296, 0) failed; error='Cannot allocate memory' (errno=12) # There is insufficient memory for the Java Runtime Environment to continue. Native memory allocation (mmap) failed to map 100663296 bytes for committing reserved memory. An error report file with more information is saved as: /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-tests/target/hs_err_pid9818.log Running org.apache.flink.test.checkpointing.WindowCheckpointingITCase ERROR: Maven JVM terminated unexpectedly with exit code 137 Putting comment on the pull request Finished: FAILURE ``` But I run it successfully in my environment, does it a Jenkins memory problem? Rerun it in Jenkins?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong closed the pull request at:

          https://github.com/apache/flink/pull/2439

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong closed the pull request at: https://github.com/apache/flink/pull/2439
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user liuyuzhong reopened a pull request:

          https://github.com/apache/flink/pull/2439

          FLINK-4450update storm verion to 1.0.0 in flink-storm and flink-storm-examples

          This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450

          Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype." to "org.apache.", and this change will work for all the storm which version higher than 1.0.0

          build successfully and run successfully in my test environment.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/liuyuzhong/flink master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2439.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2439


          commit eeb1fc284d6879404b05eab422ed898a9440cdb5
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-29T11:03:15Z

          #4450 update storm version to 1.0.0

          commit 055743ad65c6213e8fe8d422e929e795c3bad8f1
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:05:08Z

          #4450 update storm version to 1.0.0 in flink-storm-examples

          commit 409827d8e7ac69743b9c7f98774c001f6551457c
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:10:47Z

          #4450 reverse for uncorrect change submit pom.xml

          commit eebd8c534933fb2639dc248469ba56a2ed053cb7
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:12:00Z

          #4450 reverse for uncorrect change submit pom.xml

          commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-08-30T06:14:44Z

          Merge pull request #1 from liuyuzhong/4450

          #4450 update storm version to 1.0.0

          commit 89d04437c74567fe21949f0b3ac5730e42002db2
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-31T03:12:14Z

          #4450 exclusion unnecessary dependency in flink-storm

          commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-31T03:14:21Z

          #4450 delete LocalCluster storm topology test

          commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-08-31T03:26:21Z

          Merge pull request #2 from liuyuzhong/4450

          4450


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user liuyuzhong reopened a pull request: https://github.com/apache/flink/pull/2439 FLINK-4450 update storm verion to 1.0.0 in flink-storm and flink-storm-examples This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450 Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype. " to "org.apache. ", and this change will work for all the storm which version higher than 1.0.0 build successfully and run successfully in my test environment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liuyuzhong/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2439 commit eeb1fc284d6879404b05eab422ed898a9440cdb5 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-29T11:03:15Z #4450 update storm version to 1.0.0 commit 055743ad65c6213e8fe8d422e929e795c3bad8f1 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:05:08Z #4450 update storm version to 1.0.0 in flink-storm-examples commit 409827d8e7ac69743b9c7f98774c001f6551457c Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:10:47Z #4450 reverse for uncorrect change submit pom.xml commit eebd8c534933fb2639dc248469ba56a2ed053cb7 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:12:00Z #4450 reverse for uncorrect change submit pom.xml commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf Author: liuyuzhong <darezhong@qq.com> Date: 2016-08-30T06:14:44Z Merge pull request #1 from liuyuzhong/4450 #4450 update storm version to 1.0.0 commit 89d04437c74567fe21949f0b3ac5730e42002db2 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-31T03:12:14Z #4450 exclusion unnecessary dependency in flink-storm commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-31T03:14:21Z #4450 delete LocalCluster storm topology test commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1 Author: liuyuzhong <darezhong@qq.com> Date: 2016-08-31T03:26:21Z Merge pull request #2 from liuyuzhong/4450 4450
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2439#discussion_r76975599

          — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java —
          @@ -186,15 +177,15 @@ public void testCreateTopologyContext() {
          .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId)
          .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId);

          • LocalCluster cluster = new LocalCluster();
              • End diff –

          Why `did you modify this code?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2439#discussion_r76975599 — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java — @@ -186,15 +177,15 @@ public void testCreateTopologyContext() { .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId) .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId); LocalCluster cluster = new LocalCluster(); End diff – Why `did you modify this code?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2439#discussion_r76975635

          — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/SpoutOutputCollectorObserverTest.java —
          @@ -17,14 +17,15 @@
          */
          package org.apache.flink.storm.util;

          -import backtype.storm.spout.SpoutOutputCollector;
          +import org.apache.storm.spout.SpoutOutputCollector;

          import org.junit.Assert;
          import org.junit.Test;

          import static org.mockito.Mockito.mock;

          -public class SpoutOutputCollectorObserverTest {
          — End diff –

          please remove the line break

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2439#discussion_r76975635 — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/SpoutOutputCollectorObserverTest.java — @@ -17,14 +17,15 @@ */ package org.apache.flink.storm.util; -import backtype.storm.spout.SpoutOutputCollector; +import org.apache.storm.spout.SpoutOutputCollector; import org.junit.Assert; import org.junit.Test; import static org.mockito.Mockito.mock; -public class SpoutOutputCollectorObserverTest { — End diff – please remove the line break
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2439

          There is an interesting question about how to proceed with that.

          If we merge this, the compatibility layer will only support Storm 1.0 programs, which are incompatible with prior versions. I would assume a lot of people have Storm jobs with prior versions.

          In some sense we would need two compatibility projects, one for Storm pre-1.0 and one for Storm post-1.0.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 There is an interesting question about how to proceed with that. If we merge this, the compatibility layer will only support Storm 1.0 programs, which are incompatible with prior versions. I would assume a lot of people have Storm jobs with prior versions. In some sense we would need two compatibility projects, one for Storm pre-1.0 and one for Storm post-1.0.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          @StephanEwen
          If we merge this, flink-storm will compatible with all the storm which version higher than 1.0.0

          And we can import "storm-rename-hack" to compatible with previous storm version. It can change class package name previous storm version jar.

          see the detail: https://github.com/apache/storm/tree/master/storm-rename-hack

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen If we merge this, flink-storm will compatible with all the storm which version higher than 1.0.0 And we can import "storm-rename-hack" to compatible with previous storm version. It can change class package name previous storm version jar. see the detail: https://github.com/apache/storm/tree/master/storm-rename-hack
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          close it, and will open new pull request later

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 close it, and will open new pull request later
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong closed the pull request at:

          https://github.com/apache/flink/pull/2439

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong closed the pull request at: https://github.com/apache/flink/pull/2439
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user liuyuzhong reopened a pull request:

          https://github.com/apache/flink/pull/2439

          FLINK-4450update storm verion to 1.0.0 in flink-storm and flink-storm-examples

          This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450

          Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype." to "org.apache.", and this change will work for all the storm which version higher than 1.0.0

          build successfully and run successfully in my test environment.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/liuyuzhong/flink master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2439.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2439


          commit eeb1fc284d6879404b05eab422ed898a9440cdb5
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-29T11:03:15Z

          #4450 update storm version to 1.0.0

          commit 055743ad65c6213e8fe8d422e929e795c3bad8f1
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:05:08Z

          #4450 update storm version to 1.0.0 in flink-storm-examples

          commit 409827d8e7ac69743b9c7f98774c001f6551457c
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:10:47Z

          #4450 reverse for uncorrect change submit pom.xml

          commit eebd8c534933fb2639dc248469ba56a2ed053cb7
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-30T06:12:00Z

          #4450 reverse for uncorrect change submit pom.xml

          commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-08-30T06:14:44Z

          Merge pull request #1 from liuyuzhong/4450

          #4450 update storm version to 1.0.0

          commit 89d04437c74567fe21949f0b3ac5730e42002db2
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-31T03:12:14Z

          #4450 exclusion unnecessary dependency in flink-storm

          commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-08-31T03:14:21Z

          #4450 delete LocalCluster storm topology test

          commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-08-31T03:26:21Z

          Merge pull request #2 from liuyuzhong/4450

          4450

          commit 33bd4f377074cd680299891a97734cd8658b4129
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-01T04:58:56Z

          #4450 sync to https://github.com/apache/flink.git

          commit 3be5a1b1ec12ffb22eea5695c51723129d566a98
          Author: liuyuzhong <darezhong@qq.com>
          Date: 2016-09-01T05:02:14Z

          Merge pull request #3 from liuyuzhong/4450

          #4450 sync to https://github.com/apache/flink.git

          commit a0dfde6b70fe5c12bee0a9257cfa0c3a1bb19fac
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-01T05:32:43Z

          sync to https://github.com/apache/flink.git

          commit 3afe545558295e7284974d157d56be4d8829510b
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-01T05:33:11Z

          Merge branch 'FLINK-4450'

          commit c8f63e7cfffc529c4c383ffebc01832b7c480bfa
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-05T02:02:56Z

          Merge remote-tracking branch 'upstream/master'

          commit 5f4cf236609913739b1ce537c22ee64dc205b0f0
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-06T04:34:35Z

          Merge remote-tracking branch 'upstream/master'

          commit 7d67a858277faa4b64b63fa5936bac64ad56449d
          Author: yuzhongliu <yuzhongliu@tencent.com>
          Date: 2016-09-20T06:37:42Z

          Merge remote-tracking branch 'upstream/master'


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user liuyuzhong reopened a pull request: https://github.com/apache/flink/pull/2439 FLINK-4450 update storm verion to 1.0.0 in flink-storm and flink-storm-examples This pull is for update storm version to 1.0.0 https://issues.apache.org/jira/browse/FLINK-4450 Because Apache Storm version after 1.0.0, the pacakge name was changed from "backtype. " to "org.apache. ", and this change will work for all the storm which version higher than 1.0.0 build successfully and run successfully in my test environment. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liuyuzhong/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2439 commit eeb1fc284d6879404b05eab422ed898a9440cdb5 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-29T11:03:15Z #4450 update storm version to 1.0.0 commit 055743ad65c6213e8fe8d422e929e795c3bad8f1 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:05:08Z #4450 update storm version to 1.0.0 in flink-storm-examples commit 409827d8e7ac69743b9c7f98774c001f6551457c Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:10:47Z #4450 reverse for uncorrect change submit pom.xml commit eebd8c534933fb2639dc248469ba56a2ed053cb7 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-30T06:12:00Z #4450 reverse for uncorrect change submit pom.xml commit 8788b0eb2146f3a7bb3d0af2ae61cabc7741f6bf Author: liuyuzhong <darezhong@qq.com> Date: 2016-08-30T06:14:44Z Merge pull request #1 from liuyuzhong/4450 #4450 update storm version to 1.0.0 commit 89d04437c74567fe21949f0b3ac5730e42002db2 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-31T03:12:14Z #4450 exclusion unnecessary dependency in flink-storm commit 3a20d1957a986daa0eb4758d701cd9cd0ac98839 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-08-31T03:14:21Z #4450 delete LocalCluster storm topology test commit 5765f2d51e6e84d82f2697d2c7ad7656ca8708c1 Author: liuyuzhong <darezhong@qq.com> Date: 2016-08-31T03:26:21Z Merge pull request #2 from liuyuzhong/4450 4450 commit 33bd4f377074cd680299891a97734cd8658b4129 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-01T04:58:56Z #4450 sync to https://github.com/apache/flink.git commit 3be5a1b1ec12ffb22eea5695c51723129d566a98 Author: liuyuzhong <darezhong@qq.com> Date: 2016-09-01T05:02:14Z Merge pull request #3 from liuyuzhong/4450 #4450 sync to https://github.com/apache/flink.git commit a0dfde6b70fe5c12bee0a9257cfa0c3a1bb19fac Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-01T05:32:43Z sync to https://github.com/apache/flink.git commit 3afe545558295e7284974d157d56be4d8829510b Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-01T05:33:11Z Merge branch ' FLINK-4450 ' commit c8f63e7cfffc529c4c383ffebc01832b7c480bfa Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-05T02:02:56Z Merge remote-tracking branch 'upstream/master' commit 5f4cf236609913739b1ce537c22ee64dc205b0f0 Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-06T04:34:35Z Merge remote-tracking branch 'upstream/master' commit 7d67a858277faa4b64b63fa5936bac64ad56449d Author: yuzhongliu <yuzhongliu@tencent.com> Date: 2016-09-20T06:37:42Z Merge remote-tracking branch 'upstream/master'
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2439#discussion_r80458706

          — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java —
          @@ -186,15 +177,15 @@ public void testCreateTopologyContext() {
          .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId)
          .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId);

          • LocalCluster cluster = new LocalCluster();
              • End diff –

          It can't work, so delete it first.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on a diff in the pull request: https://github.com/apache/flink/pull/2439#discussion_r80458706 — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java — @@ -186,15 +177,15 @@ public void testCreateTopologyContext() { .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId) .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId); LocalCluster cluster = new LocalCluster(); End diff – It can't work, so delete it first.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2439#discussion_r80458736

          — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/SpoutOutputCollectorObserverTest.java —
          @@ -17,14 +17,15 @@
          */
          package org.apache.flink.storm.util;

          -import backtype.storm.spout.SpoutOutputCollector;
          +import org.apache.storm.spout.SpoutOutputCollector;

          import org.junit.Assert;
          import org.junit.Test;

          import static org.mockito.Mockito.mock;

          -public class SpoutOutputCollectorObserverTest {
          — End diff –

          Fixed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on a diff in the pull request: https://github.com/apache/flink/pull/2439#discussion_r80458736 — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/SpoutOutputCollectorObserverTest.java — @@ -17,14 +17,15 @@ */ package org.apache.flink.storm.util; -import backtype.storm.spout.SpoutOutputCollector; +import org.apache.storm.spout.SpoutOutputCollector; import org.junit.Assert; import org.junit.Test; import static org.mockito.Mockito.mock; -public class SpoutOutputCollectorObserverTest { — End diff – Fixed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Jenkins run successful, but CI fail.

          ![image](https://cloud.githubusercontent.com/assets/12843176/18897594/2c9e40e2-855e-11e6-8d3c-0397b33d5d8f.png)

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Jenkins run successful, but CI fail. ! [image] ( https://cloud.githubusercontent.com/assets/12843176/18897594/2c9e40e2-855e-11e6-8d3c-0397b33d5d8f.png )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          *Jenkins run error*
          1.build success
          ```
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 01:18 h
          [INFO] Finished at: 2016-10-09T12:42:31+00:00
          [INFO] Final Memory: 210M/1154M
          ```

          2.finish fail:
          ```
          [JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-contrib/flink-streaming-contrib/target/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar to org.apache.flink/flink-streaming-contrib_2.10/1.2-SNAPSHOT/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar
          channel stopped
          Putting comment on the pull request
          Finished: UNSTABLE
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 * Jenkins run error * 1.build success ``` [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:18 h [INFO] Finished at: 2016-10-09T12:42:31+00:00 [INFO] Final Memory: 210M/1154M ``` 2.finish fail: ``` [JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/flink-github-ci/flink-contrib/flink-streaming-contrib/target/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar to org.apache.flink/flink-streaming-contrib_2.10/1.2-SNAPSHOT/flink-streaming-contrib_2.10-1.2-SNAPSHOT-javadoc.jar channel stopped Putting comment on the pull request Finished: UNSTABLE ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2439#discussion_r82567287

          — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java —
          @@ -186,15 +177,15 @@ public void testCreateTopologyContext() {
          .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId)
          .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId);

          • LocalCluster cluster = new LocalCluster();
              • End diff –

          Can you elaborate a bit why this cannot work any more with Storm 1.0?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2439#discussion_r82567287 — Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java — @@ -186,15 +177,15 @@ public void testCreateTopologyContext() { .shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId) .shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId); LocalCluster cluster = new LocalCluster(); End diff – Can you elaborate a bit why this cannot work any more with Storm 1.0?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          @StephanEwen Actually, I'm not very clear about Clojure Web FrameWork, but it's web framework are using "ring.ring-core".
          import: https://github.com/apache/storm/blob/1.x-branch/pom.xml#L703
          code detail: https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/ui/helpers.clj#L36

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Actually, I'm not very clear about Clojure Web FrameWork, but it's web framework are using "ring.ring-core". import: https://github.com/apache/storm/blob/1.x-branch/pom.xml#L703 code detail: https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/ui/helpers.clj#L36
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2439

          Okay, then we should re-add all the dependency exclusions that were removed from the `flink-storm/pom.xml`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 Okay, then we should re-add all the dependency exclusions that were removed from the `flink-storm/pom.xml`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2439

          I would like to merge this. But I think we need to change back the dependency exclusions in `flink-storm/pom.xml` to as they are in the current master.

          Can you do that? Then I will merge this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 I would like to merge this. But I think we need to change back the dependency exclusions in `flink-storm/pom.xml` to as they are in the current master. Can you do that? Then I will merge this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Sorry.forget to check it. I will do it tomorrow.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Sorry.forget to check it. I will do it tomorrow.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          @StephanEwen Fixed. Help me to review it please.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Fixed. Help me to review it please.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2439

          I think this is getting into good shape, we can almost merge it.
          Two things remaining:

          1. Can you rebase/squash all commits into one commit?
          2. There is a complilation error, probably a missing dependency, see below.

          Hope that when those are addresses, we can merge this.

          ```
          [INFO] -------------------------------------------------------------
          [ERROR] COMPILATION ERROR :
          [INFO] -------------------------------------------------------------
          [ERROR] /home/travis/build/apache/flink/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java:[30,23] package org.json.simple does not exist
          [INFO] 1 error
          [INFO] -------------------------------------------------------------
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 I think this is getting into good shape, we can almost merge it. Two things remaining: 1. Can you rebase/squash all commits into one commit? 2. There is a complilation error, probably a missing dependency, see below. Hope that when those are addresses, we can merge this. ``` [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/travis/build/apache/flink/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java: [30,23] package org.json.simple does not exist [INFO] 1 error [INFO] ------------------------------------------------------------- ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Fixed complie error.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Fixed complie error.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Complie error is fixed. But how to squash all commits into one commit?

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Complie error is fixed. But how to squash all commits into one commit?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2439

          Thanks!

          You can squash commits by rebasing. Have a look here: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2439 Thanks! You can squash commits by rebasing. Have a look here: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          Sorry, something was wrong when I am rebase.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 Sorry, something was wrong when I am rebase.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          @StephanEwen Sorry, I can't continue with this pull request. I will use another githup account to pull.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen Sorry, I can't continue with this pull request. I will use another githup account to pull.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          @StephanEwen I use new githup account make a new pull request #3037, help me to review it please.Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 @StephanEwen I use new githup account make a new pull request #3037, help me to review it please.Thanks.
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via 475c0b1a6c74744e3431b268bc1a2ee764052cf1

          Thank you for the contribution!

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via 475c0b1a6c74744e3431b268bc1a2ee764052cf1 Thank you for the contribution!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/2439

          Please close this since there is a newer PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2439 Please close this since there is a newer PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong commented on the issue:

          https://github.com/apache/flink/pull/2439

          #3037 has merged. done.

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong commented on the issue: https://github.com/apache/flink/pull/2439 #3037 has merged. done.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user liuyuzhong closed the pull request at:

          https://github.com/apache/flink/pull/2439

          Show
          githubbot ASF GitHub Bot added a comment - Github user liuyuzhong closed the pull request at: https://github.com/apache/flink/pull/2439

            People

            • Assignee:
              Unassigned
              Reporter:
              yuzhongliu yuzhongliu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development