Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4334

Shaded Hadoop1 jar not fully excluded in Quickstart

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0, 1.0.1, 1.0.2, 1.0.3
    • Fix Version/s: 1.1.2
    • Component/s: Quickstarts
    • Labels:
      None

      Description

      The Shaded Hadoop1 jar has artifactId flink-shaded-hadoop1_2.10 since Flink 1.0.0 (see https://github.com/apache/flink/commit/2c4e4d1ffaf4107fb802c90858184fc10af66837), but the quickstart POMs both refer to it as flink-shaded-hadoop1.

      If using "-Pbuild-jar", the problem is not encountered.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rehevkor5 closed the pull request at:

          https://github.com/apache/flink/pull/2341

          Show
          githubbot ASF GitHub Bot added a comment - Github user rehevkor5 closed the pull request at: https://github.com/apache/flink/pull/2341
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rehevkor5 commented on the issue:

          https://github.com/apache/flink/pull/2341

          You got it @StephanEwen

          Show
          githubbot ASF GitHub Bot added a comment - Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2341 You got it @StephanEwen
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2341

          @rehevkor5 Since the Apache bot does not automatically close this pull request, could you close it manually?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2341 @rehevkor5 Since the Apache bot does not automatically close this pull request, could you close it manually?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2341

          I merged this into the 1.1 release branch.
          For the 1.2 releases, we should use this fix: #2343

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2341 I merged this into the 1.1 release branch. For the 1.2 releases, we should use this fix: #2343
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed for 1.1.2 via fc5b58d29486d9a7e0053a508274a46de97c73aa

          Show
          StephanEwen Stephan Ewen added a comment - Fixed for 1.1.2 via fc5b58d29486d9a7e0053a508274a46de97c73aa
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2341

          Thanks, this makes a lot of sense.

          We should merge this for Flink 1.1.1
          For Flink 1.2.0, we should actually fix the root issue, which is that the hadoop1 artifact has a scala suffix even though it does not need one. I think this was introduced by accident.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2341 Thanks, this makes a lot of sense. We should merge this for Flink 1.1.1 For Flink 1.2.0, we should actually fix the root issue, which is that the hadoop1 artifact has a scala suffix even though it does not need one. I think this was introduced by accident.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rehevkor5 opened a pull request:

          https://github.com/apache/flink/pull/2341

          FLINK-4334 [quickstarts] Correctly exclude hadoop1 in quickstart POMs

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rehevkor5/flink fix_hadoop1_not_excluded_in_quickstarts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2341.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2341


          commit 8cb7419a17359f0d61d632aae97f672d497ccc53
          Author: Shannon Carey <rehevkor5@gmail.com>
          Date: 2016-08-08T20:04:23Z

          FLINK-4334 [quickstarts] Correctly exclude hadoop1 in quickstart POMs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rehevkor5 opened a pull request: https://github.com/apache/flink/pull/2341 FLINK-4334 [quickstarts] Correctly exclude hadoop1 in quickstart POMs Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/rehevkor5/flink fix_hadoop1_not_excluded_in_quickstarts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2341 commit 8cb7419a17359f0d61d632aae97f672d497ccc53 Author: Shannon Carey <rehevkor5@gmail.com> Date: 2016-08-08T20:04:23Z FLINK-4334 [quickstarts] Correctly exclude hadoop1 in quickstart POMs

            People

            • Assignee:
              Unassigned
              Reporter:
              rehevkor5 Shannon Carey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development