Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4279

[py] Set flink dependencies to provided

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.1.0
    • 1.1.0
    • API / Python
    • None

    Attachments

      Issue Links

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/2308

          FLINK-4279 [py] Set flink dependencies to provided

          • removed unused `flink-optimizer` and `flink-clients` dependency
          • set the remaining dependencies to `provided`
          • as otherwise several shaded classes were included in the jar

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 4279_python_dep

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2308.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2308


          commit 6ccb61ba228ade45f6a4e1de1ecd87cbc1129136
          Author: zentol <chesnay@apache.org>
          Date: 2016-07-29T09:38:06Z

          FLINK-4279 [py] Set flink dependencies to provided


          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2308 FLINK-4279 [py] Set flink dependencies to provided removed unused `flink-optimizer` and `flink-clients` dependency set the remaining dependencies to `provided` as otherwise several shaded classes were included in the jar You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 4279_python_dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2308.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2308 commit 6ccb61ba228ade45f6a4e1de1ecd87cbc1129136 Author: zentol <chesnay@apache.org> Date: 2016-07-29T09:38:06Z FLINK-4279 [py] Set flink dependencies to provided
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2308

          For all the connectors and other libraries (that were included into user fat jars), these changes were good.
          So, if the Python module is used in a similar way, it should make sense there as well...

          +1

          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2308 For all the connectors and other libraries (that were included into user fat jars), these changes were good. So, if the Python module is used in a similar way, it should make sense there as well... +1
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2308

          merging

          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2308 merging
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2308

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2308

          Implemented in 6edc7f1e1ebd3f545975317e82e9ea02ab168c74

          chesnay Chesnay Schepler added a comment - Implemented in 6edc7f1e1ebd3f545975317e82e9ea02ab168c74

          People

            chesnay Chesnay Schepler
            chesnay Chesnay Schepler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: