[FLINK-4258] Potential null pointer dereference in SavepointCoordinator#onFullyAcknowledgedCheckpoint

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Maximilian Michels
• Reporter: Ted Yu
• Created: 22/Jul/16 20:09
• Updated: 26/Jul/16 16:40
• Resolved: 26/Jul/16 16:40

Description

    if (promise == null) {
      LOG.info("Pending savepoint with ID " + checkpoint.getCheckpointID() + "  has been " +
          "removed before receiving acknowledgment.");
    }

    // Sanity check
    if (promise.isCompleted()) {
      throw new IllegalStateException("Savepoint promise completed");

Looks like a return statement is missing in the first if block above.