[FLINK-4083] Use ClosureCleaner for Join where and equalTo

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.3
• Fix Version/s: 1.1.0
• Assignee: Stefan Richter
• Reporter: Stefan Richter
• Created: 16/Jun/16 13:17
• Updated: 20/Jun/16 13:37
• Resolved: 20/Jun/16 13:37

Description

When specifying a key selector in the where or equalTo clause of a Join, the closure cleaner is not used. Same problem as FLINK-4078.

.join(ds)
	.where(new KeySelector<CustomType, Integer>() {
		@Override
		public Integer getKey(CustomType value) {
			return value.myInt;
		}
	})
	.equalTo(new KeySelector<CustomType, Integer>(){

		@Override
		public Integer getKey(CustomType value) throws Exception {
			return value.myInt;
		}
	});

The problem is that the KeySelector is an anonymous inner class and as such as a reference to the outer object. Normally, this would be rectified by the closure cleaner but the cleaner is not used in Join.where() and Join.equalTo().

Issue Links

• is related to: FLINK-4078 Use ClosureCleaner for CoGroup where
• links to: GitHub Pull Request #2117