Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3866

StringArraySerializer claims type is immutable; shouldn't

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.0.3
    • 1.1.2, 1.2.0
    • None
    • None

    Description

      Looking at default `TypeSerializer` instances I noticed what looks like a minor flaw, unless I am missing something.
      Whereas all other array serializers indicate that type is not immutable (since in Java, arrays are not immutable), `StringArraySerializer` has:

      ```
      @Override
      public boolean isImmutableType()

      { return true; }

      ```

      and I think it should instead return `false`. I could create a PR, but seems like a small enough thing that issue report makes more sense.
      I tried looking for deps to see if there's a test for this, but couldn't find one; otherwise could submit a test fix.

      Attachments

        Issue Links

          Activity

            People

              ivan.mushketyk Ivan Mushketyk
              cowtowncoder Tatu Saloranta
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: