Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3866

StringArraySerializer claims type is immutable; shouldn't

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.2.0, 1.1.2
    • Component/s: Core
    • Labels:
      None

      Description

      Looking at default `TypeSerializer` instances I noticed what looks like a minor flaw, unless I am missing something.
      Whereas all other array serializers indicate that type is not immutable (since in Java, arrays are not immutable), `StringArraySerializer` has:

      ```
      @Override
      public boolean isImmutableType()

      { return true; }

      ```

      and I think it should instead return `false`. I could create a PR, but seems like a small enough thing that issue report makes more sense.
      I tried looking for deps to see if there's a test for this, but couldn't find one; otherwise could submit a test fix.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ivan.mushketyk Ivan Mushketyk
                Reporter:
                cowtowncoder Tatu Saloranta
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: