[FLINK-3803] Checkpoint Stats Tracker Reads from Wrong Configuration

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.3, 1.1.0
• Assignee: Ufuk Celebi
• Reporter: Aljoscha Krettek
• Created: 22/Apr/16 11:45
• Updated: 28/Feb/19 11:14
• Resolved: 26/Apr/16 08:37

Description

In ExecutionGraph.java when configuring the checkpoint stats tracker the config values are read from the jobConfiguration:

boolean isStatsDisabled = jobConfiguration.getBoolean(
        ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_DISABLE,
        ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_DISABLE);

if (isStatsDisabled) {
    checkpointStatsTracker = new DisabledCheckpointStatsTracker();
}
else {
    int historySize = jobConfiguration.getInteger(
            ConfigConstants.JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE,
            ConfigConstants.DEFAULT_JOB_MANAGER_WEB_CHECKPOINTS_HISTORY_SIZE);

    checkpointStatsTracker = new SimpleCheckpointStatsTracker(historySize, tasksToWaitFor);
}

The settings are only available in the Flink Configuration, however. Right now, the ExecutionGraph has no access to the Flink Configuration.

I see three solutions:

• pass the Flink Configuration to the ExecutionGraph
• pass just the two required settings to the ExecutionGraph
• Introduce a new ExecutionGraphSettings that contains settings only for the ExecutionGraph in order to clean up things a bit