Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3747

Consolidate TimestampAssigner Methods in Kafka Consumer

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 1.1.0
    • None
    • None

    Description

      On DataStream the methods for setting a TimestampAssigner/WatermarkEmitter are called assignTimestampsAndWatermarks() while on FlinkKafkaConsumer* they are called setPunctuatedWatermarkEmitter() and setPeriodicWatermarkEmitter().

      I think these names should be matched, also the name setWatermarkEmitter does not hint at the fact that the assigner primarily assigns timestamps.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            aljoscha Aljoscha Krettek
            aljoscha Aljoscha Krettek
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment