[FLINK-36000] DynamicTableSink#Context's getTargetColumns should not return an array of zero length

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.20.0, 1.19.1
• Fix Version/s: 1.19.2, 1.20.1, 2.0-preview
• Component/s: Table SQL / Planner
• Labels: pull-request-available
• Assignee: lincoln lee
• Reporter: lincoln lee
• Created: 07/Aug/24 12:10
• Updated: 02/Sep/24 09:35
• Resolved: 08/Aug/24 01:26

Description

The interface [`Optional<int[][]> getTargetColumns()` |https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java#L192]

is expected to return an Optional#empty() for a sql statement without specifying a column list, e.g., 'insert into t1 select ...',

but the current implemantation will return an int[0] in such cases, this is unexpected.

 

Issue Links

• links to: GitHub Pull Request #25165
• links to: GitHub Pull Request #25172
• links to: GitHub Pull Request #25173