[FLINK-35112] Membership for Row class does not include field names

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.18.1
• Fix Version/s: 1.20.0, 1.19.1
• Component/s: API / Python
• Labels: pull-request-available
• Assignee: Wouter Zorgdrager
• Reporter: Wouter Zorgdrager
• Created: 15/Apr/24 10:11
• Updated: 11/May/24 02:56
• Resolved: 11/May/24 02:54

Description

In the Row class in PyFlink I cannot do a membership check for field names. This minimal example will show the unexpected behavior:

```

from pyflink.common import Row

row = Row(name="Alice", age=11)

1. Expected to be True, but is False
   print("name" in row)

person = Row("name", "age")

1. This is True, as expected
   print('name' in person)

```

The related code in the Row class is:
```
    def _contains_(self, item):
        return item in self._values
```

It should be relatively easy to fix with the following code:
```
    def _contains_(self, item):
        if hasattr(self, "_fields"):
            return item in self._fields
        else:
            return item in self._values
```

Issue Links

• links to: GitHub Pull Request #24756