[FLINK-34933] JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored isn't implemented properly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.2, 1.19.0, 1.18.1, 1.20.0
• Fix Version/s: 1.18.2, 1.20.0, 1.19.1
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Matthias Pohl
• Reporter: Matthias Pohl
• Created: 25/Mar/24 15:41
• Updated: 28/Mar/24 13:01
• Resolved: 28/Mar/24 13:01

Description

testResultFutureCompletionOfOutdatedLeaderIsIgnored doesn't test the desired behavior: The TestingJobMasterService#closeAsync() callback throws an UnsupportedOperationException by default which prevents the test from properly finalizing the leadership revocation.

The test is still passing because the test checks implicitly for this error. Instead, we should verify that the runner's resultFuture doesn't complete until the runner is closed.

Issue Links

• Discovered while testing: FLINK-34672 HA deadlock between JobMasterServiceLeadershipRunner and DefaultLeaderElectionService
• links to: GitHub Pull Request #24562
• links to: GitHub Pull Request #24584
• links to: GitHub Pull Request #24585