Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-34715

Fix mysql ut about closing BinlogSplitReader

    XMLWordPrintableJSON

Details

    Description

      BinlogSplitReaderTest#readBinlogSplitsFromSnapshotSplits should test binlog reader is closed after binlog reader close. But code always test snapshot split reader is closed.

      binlogReader.close();
      assertNotNull(snapshotSplitReader.getExecutorService());
      assertTrue(snapshotSplitReader.getExecutorService().isTerminated());

      We shoud change code to 

      binlogReader.close();
      assertNotNull(binlogReader.getExecutorService());
      assertTrue(binlogReader.getExecutorService().isTerminated()); 

       

      Attachments

        Issue Links

          Activity

            People

              pacinogong Xin Gong
              pacinogong Xin Gong
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: