Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3469

Improve documentation for grouping keys

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.0
    • 1.0.1, 1.1.0
    • Documentation
    • None

    Description

      The transformation documentation for "Reduce on DataSet Grouped by KeySelector Function" uses a field expression in the Java example.

      There are four ways to specify keys and only two have named examples in the documentation. Expand the documentation to cover all cases.

      Attachments

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/1858

          FLINK-3469 Improve documentation for grouping keys

          Updates the documentation with examples for the four methods for specifying keys and places the examples into the proper category.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 3469_improve_documentation_for_grouping_keys

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/1858.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1858


          commit 7bca344adca9eb3386c1754cf99868f12761ef91
          Author: Greg Hogan <code@greghogan.com>
          Date: 2016-04-06T19:44:47Z

          FLINK-3469 Improve documentation for grouping keys


          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1858 FLINK-3469 Improve documentation for grouping keys Updates the documentation with examples for the four methods for specifying keys and places the examples into the proper category. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 3469_improve_documentation_for_grouping_keys Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1858.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1858 commit 7bca344adca9eb3386c1754cf99868f12761ef91 Author: Greg Hogan <code@greghogan.com> Date: 2016-04-06T19:44:47Z FLINK-3469 Improve documentation for grouping keys
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the pull request:

          https://github.com/apache/flink/pull/1858#issuecomment-207507759

          +1 to merge

          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1858#issuecomment-207507759 +1 to merge
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the pull request:

          https://github.com/apache/flink/pull/1858#issuecomment-208313033

          Merging this together with #1817.

          githubbot ASF GitHub Bot added a comment - Github user uce commented on the pull request: https://github.com/apache/flink/pull/1858#issuecomment-208313033 Merging this together with #1817.
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/1858

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1858
          uce Ufuk Celebi added a comment -

          Fixed in 0e43ce9 (release-1.0), e16ca84 (master).

          uce Ufuk Celebi added a comment - Fixed in 0e43ce9 (release-1.0), e16ca84 (master).

          People

            greghogan Greg Hogan
            greghogan Greg Hogan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: