[FLINK-34434] DefaultSlotStatusSyncer doesn't complete the returned future

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.2, 1.19.0, 1.18.1, 1.20.0
• Fix Version/s: 1.19.0, 1.18.2, 1.20.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Yangze Guo
• Reporter: Matthias Pohl
• Created: 13/Feb/24 11:10
• Updated: 20/Feb/24 06:03
• Resolved: 20/Feb/24 06:03

Description

When looking into FLINK-34427 (unrelated), I noticed an odd line in DefaultSlotStatusSyncer:155 where we complete a future that should be already completed (because the callback is triggered after the requestFuture is already completed in some way. Shouldn't we complete the returnedFuture instead?

I'm keeping the priority at Major because it doesn't seem to have been an issue in the past.

Issue Links

• is caused by: FLINK-20835 Implement FineGrainedSlotManager
• links to: GitHub Pull Request #24325