[FLINK-3434] Return value from flinkYarnClient#deploy() should be checked against null

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Assignee: Chesnay Schepler
• Reporter: Ted Yu
• Created: 17/Feb/16 13:40
• Updated: 26/Feb/16 12:33
• Resolved: 26/Feb/16 12:33

Description

In CliFrontend#getClient() :

        yarnCluster = flinkYarnClient.deploy();
        yarnCluster.connectToCluster();

Looking at FlinkYarnClientBase#deployInternal(), null return is possible:

    try {
      org.apache.flink.core.fs.FileSystem.setDefaultScheme(flinkConfiguration);
    } catch (IOException e) {
      LOG.error("Error while setting the default " +
        "filesystem scheme from configuration.", e);
      return null;
    }

We should check the return from deploy() before calling connectToCluster().