[FLINK-34271] Fix the potential failure test about GroupAggregateRestoreTest#AGG_WITH_STATE_TTL_HINT

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.19.0
• Component/s: Table SQL / Planner
• Labels: pull-request-available
• Assignee: xuyang
• Reporter: xuyang
• Created: 30/Jan/24 05:58
• Updated: 31/Jan/24 13:33
• Resolved: 31/Jan/24 13:33

Description

The underlying reason is that a previous PR introduced a test with state TTL as follows in the SQL: 

.runSql(
        "INSERT INTO sink_t SELECT /*+ STATE_TTL('source_t' = '4d') */"
                + "b, "
                + "COUNT(*) AS cnt, "
                + "AVG(a) FILTER (WHERE a > 1) AS avg_a, "
                + "MIN(c) AS min_c "
                + "FROM source_t GROUP BY b")

When the savepoint metadata was generated for the first time, the metadata recorded the time when a certain key was accessed. If the test is rerun after the TTL has expired, the state of this key in the metadata will be cleared, resulting in an incorrect test outcome.

To rectify this issue, I think the current tests in RestoreTestBase could be modified to regenerate a new savepoint metadata as needed every time. However, this seems to deviate from the original design purpose of RestoreTestBase.

For my test, I will work around this by removing the data "consumedBeforeRestore", as I am only interested in testing the generation of an expected JSON plan.

Issue Links

• is caused by: FLINK-34053 Support state TTL hint for group aggregate
• links to: GitHub Pull Request #24226