Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3412

Remove implicit conversions JavaStream / ScalaStream

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.10.2
    • 1.0.0
    • API / Scala
    • None

    Description

      I think the implicit conversions between the Java DataStream and the Scala DataStream are dangerous.

      Because conversions exist in both directions, it is possible to write methods that look like calling functions on the JavaStream, but instead convert it to a Scala stream and call a different method.
      I just accidentally implemented an infinite recursion that way (via two hidden implicit conversions).

      Making the conversions explicit (with a wrap() function like in the batch API, we add minimally more code internally (nothing is different for users), but avoid such accidental errors.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sewen Stephan Ewen
            sewen Stephan Ewen
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment