[FLINK-33938] Correct implicit coercions in relational operators to adopt typescript 5.0

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.19.0, 1.17.3, 1.18.2
• Component/s: Runtime / Web Frontend
• Labels: pull-request-available
• Assignee: Ao Yuchen
• Reporter: Ao Yuchen
• Created: 26/Dec/23 02:48
• Updated: 09/Jan/24 06:58
• Resolved: 09/Jan/24 06:58

Description

Since TypeScript 5.0, there is a break change that implicit coercions in relational operators are forbidden [1].

So that the following code in flink-runtime-web/web-dashboard/src/app/components/humanize-date.pipe.ts get error:

public transform(
  value: number | string | Date,
  ...
): string | null | undefined {
  if (value == null || value === '' || value !== value || value < 0) {
    return '-';
  } 
  ...
}

The correctness improvement is availble in here [2].

I think we should optimize this type of code for better compatibility.

 

[1] https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#forbidden-implicit-coercions-in-relational-operators

[2] https://github.com/microsoft/TypeScript/pull/52048

Issue Links

• links to: GitHub Pull Request #23999