Details
-
Improvement
-
Status: Closed
-
Critical
-
Resolution: Fixed
-
0.10.1
-
None
-
None
Description
Based on a lot of user feedback, the current TimestampExtractor seems very confusing. It implements simultaneously two modes of generating watermarks:
- Each record that passes through can decide to cause a watermark.
- The timestamp extractor can define a certain watermark timestamp which is periodically picked up by the system and triggers a watermark (if larger than the previous watermark).
Figuring out how these modes interplay, and how to define the methods to only use one mode has been quite an obstacle for several users. We should break this class into two different classes, one per mode of generating watermarks, to make it easier to understand.