Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3377

Remove final flag from ResultPartitionWriter class

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • 0.10.1
    • 1.0.0
    • Runtime / Coordination
    • None

    Description

      The final flag on the org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter class is causing issues for me.

      The flag requires me to run a test I'm working on with a @RunWith(PowerMockRunner.class) annotation so that i can use @PrepareForTest(

      {ResultPartitionWriter.class}

      ).
      But it breaks my TemporaryFolder annotated with @ClassRule. (apart from that there also was a classloader issue, but i could resolve that)

      To me these seem like unnecessary problems, as such i propose removing the final flag.

      The

      Attachments

        Activity

          People

            chesnay Chesnay Schepler
            chesnay Chesnay Schepler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: