[FLINK-33367] Invalid Check in DefaultFileFilter

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.16.2
• Component/s: Connectors / FileSystem
• Release Note: Not an actual issue.
• Assignee: Unassigned
• Reporter: Chirag Dewan
• Created: 26/Oct/23 05:28
• Updated: 27/Oct/23 14:39
• Resolved: 26/Oct/23 19:29

Description

There is a null check in DefaultFileFilter:

 

if (fileName == null || fileName.length() == 0)

{   return true; }

 

So 2 questions here -

1) Can a file name ever be null?

2) What will be the behavior with return true? Should it be return false rather?