[FLINK-33156] Remove flakiness from tests in OperatorStateBackendTest.java

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.17.1
• Fix Version/s: 1.17.1
• Component/s: Runtime / State Backends
• Labels: pull-request-available
• Assignee: Asha Boyapati
• Reporter: Asha Boyapati
• Created: 26/Sep/23 05:51
• Updated: 29/Sep/23 14:46

Description

This issue is similar to:
https://issues.apache.org/jira/browse/FLINK-32963

We are proposing to make the following tests stable:

org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreSync
org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreAsync

The tests are currently flaky because the order of elements returned by iterators is non-deterministic.

The following PR fixes the flaky test by making them independent of the order of elements returned by the iterator:
https://github.com/apache/flink/pull/23464

We detected this using the NonDex tool using the following commands:

mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl flink-runtime -DnondexRuns=10 -Dtest=org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreSync

mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl flink-runtime -DnondexRuns=10 -Dtest=org.apache.flink.runtime.state.OperatorStateBackendTest#testSnapshotRestoreAsync

Please see the following Continuous Integration log that shows the flakiness:
https://github.com/asha-boyapati/flink/actions/runs/6193757385

Please see the following Continuous Integration log that shows that the flakiness is fixed by this change:
https://github.com/asha-boyapati/flink/actions/runs/6194044449

Issue Links

• links to: GitHub Pull Request #23464