[FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.18.0
• Fix Version/s: 1.19.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Panagiotis Garefalakis
• Reporter: Matt Wang
• Created: 04/Sep/23 08:49
• Updated: 15/Sep/23 02:21
• Resolved: 15/Sep/23 02:21

Description

if we configurate the `jobmanager.failure-enrichers`, but could not load the class in 
FailureEnricherUtils, no exceptions can be seen in the log currently, and it is very inconvenient to check the problem. Here I suggest that some ERROR-level logs should be added, or an exception should be thrown directly (because the load cannot be uploaded is not an expected result)

// code placeholder
@VisibleForTesting
static Collection<FailureEnricher> getFailureEnrichers(
        final Configuration configuration, final PluginManager pluginManager) {
    Set<String> includedEnrichers = getIncludedFailureEnrichers(configuration);
    LOG.info("includedEnrichers: {}", includedEnrichers);
    //  When empty, NO enrichers will be started.
    if (includedEnrichers.isEmpty()) {
        return Collections.emptySet();
    }
    // TODO: here maybe load nothing
    final Iterator<FailureEnricherFactory> factoryIterator =
            pluginManager.load(FailureEnricherFactory.class);
    ....
} 

 

Issue Links

• is required by: FLINK-32804 Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink
• links to: GitHub Pull Request #23386