Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-25325 Migration Flink from Junit4 to Junit5
  3. FLINK-32866

Unify the TestLoggerExtension config of junit5

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: In Progress
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • Tests

    Description

      Some modules added the TestLoggerExtension to the org.junit.jupiter.api.extension.Extension resource file. All test classes of these modules don't need add the @ExtendWith(TestLoggerExtension.class) at class level.

      This JIRA propose clean up the @ExtendWith(TestLoggerExtension.class) for modules that added the TestLoggerExtension to the org.junit.jupiter.api.extension.Extension resource file.

      Update: We could also investigate in what extend we could remove the org.junit.jupiter.api.extension.Extension resource files from certain modules. It only has to be present once on the classpath. A single location for this configuration would be nice (e.g. putting it in flink-test-utils-parent/flink-test-utils-junit). But I think not all modules have this one as there dependency. So, having a single resource file for configuring this might be not possible. But at least, we can reduce the number of files to a minimum.

      Attachments

        Issue Links

          Activity

            People

              fanrui Rui Fan
              fanrui Rui Fan
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: