[FLINK-32689] Insufficient validation for table.local-time-zone

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.18.0
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: Timo Walther
• Reporter: Timo Walther
• Created: 26/Jul/23 14:41
• Updated: 07/Aug/23 14:41
• Resolved: 07/Aug/23 14:41

Description

There are still cases where timezone information is lost silently due to the interaction between java.util.TimeZone and java.time.ZoneId.

This might be theoretical problem, but I would feel safer if we change the check to:

if (!java.util.TimeZone.getTimeZone(zoneId).toZoneId().equals(ZoneId.of(zoneId))) {
   throw new ValidationException(errorMessage);
}

Issue Links

• links to: GitHub Pull Request #23090