[FLINK-32495] SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.18.0, 1.16.3, 1.17.2
• Component/s: Connectors / Common
• Labels: pull-request-available
• Assignee: Rui Fan
• Reporter: Rui Fan
• Created: 30/Jun/23 02:57
• Updated: 30/Jun/23 12:15
• Resolved: 30/Jun/23 12:15

Description

SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails.

I analyzed this CI :  https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=50668&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=9089

Root cause:

• The CoordinatorExecutorThreadFactory cannot new multiple threads. And too many callers will check `coordinatorThreadFactory.isCurrentThreadCoordinatorThread()`, such as: SourceCoordinatorContext.attemptReady.
• The CoordinatorExecutorThreadFactory is shared at SourceCoordinatorTestBase
• It will be used at multiple source coordinator, and the second source coordinator will overwrite the CoordinatorExecutorThreadFactory#t, so the check will fail for the first source.

Solution:

Don't share the CoordinatorExecutorThreadFactory.

log:

 

 

Issue Links

• is caused by: FLINK-32478 SourceCoordinatorAlignmentTest.testAnnounceCombinedWatermarkWithoutStart fails
• links to: GitHub Pull Request #22910
• links to: GitHub Pull Request #22911
• links to: GitHub Pull Request #22912