[FLINK-32421] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.2, 1.18.0, 1.17.1
• Fix Version/s: 1.18.0, 1.16.3, 1.17.2
• Component/s: Runtime / Coordination, Tests
• Labels: pull-request-available
• Assignee: Matthias Pohl
• Reporter: Matthias Pohl
• Created: 23/Jun/23 15:51
• Updated: 05/Jul/23 15:52
• Resolved: 05/Jul/23 15:52

Description

The purpose of EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is to check that there is no NullPointerException happening if the event processing happens after the shutdown of the EmbeddedExecutorService (see FLINK-11855).

But the concurrent execution is not handled properly. The test also succeeds if the close call happened before the shutdown (due to the multi-threaded nature of the test) which leaves us without the actual test scenario being tested.

Issue Links

• links to: GitHub Pull Request #22865
• links to: GitHub Pull Request #22871
• links to: GitHub Pull Request #22872