Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3210

Unnecessary call to deserializer#deserialize() in LegacyFetcher#SimpleConsumerThread#run()

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Later
    • None
    • None
    • None
    • None

    Description

      Here is related code:

                      byte[] valueBytes;
                      if (payload == null) {
                        deletedMessages++;
                        valueBytes = null;
                      } else {
      ...
                      final T value = deserializer.deserialize(keyBytes, valueBytes, fp.topic, offset);
      

      When valueBytes is null, there is no need to call deserializer#deserialize()

      Attachments

        Activity

          People

            Unassigned Unassigned
            yuzhihong@gmail.com Ted Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: