[FLINK-31244] OffHeapUnsafeMemorySegmentTest.testCallCleanerOnceOnConcurrentFree prints IllegalStateException

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.17.0, 1.15.3, 1.16.1
• Component/s: Runtime / Network, Tests
• Labels: auto-deprioritized-major starter test-stability
• Assignee: Unassigned
• Reporter: Matthias Pohl
• Created: 27/Feb/23 12:57
• Updated: 19/Aug/23 10:35

Description

We're observing strange IllegalStateException stacktrace output in OffHeapUnsafeMemorySegmentTest.testCallCleanerOnceOnConcurrentFree in CI like:

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46283&view=logs&j=4d4a0d10-fca2-5507-8eed-c07f0bdf4887&t=7b25afdf-cc6c-566f-5459-359dc2585798&l=5584 

Feb 18 03:58:47 [INFO] Running org.apache.flink.core.memory.OffHeapUnsafeMemorySegmentTest
Exception in thread "Thread-13" java.lang.IllegalStateException: MemorySegment can be freed only once!
    at org.apache.flink.core.memory.MemorySegment.free(MemorySegment.java:244)
    at java.lang.Thread.run(Thread.java:748)
Exception in thread "Thread-15" java.lang.IllegalStateException: MemorySegment can be freed only once!
    at org.apache.flink.core.memory.MemorySegment.free(MemorySegment.java:244)
    at java.lang.Thread.run(Thread.java:748)
Exception in thread "Thread-17" java.lang.IllegalStateException: MemorySegment can be freed only once!
    at org.apache.flink.core.memory.MemorySegment.free(MemorySegment.java:244)
    at java.lang.Thread.run(Thread.java:748)

This is caused by FLINK-21798. The corresponding system property is enabled as part of the CI run (see tools/ci/test_controller.sh:108) which makes the IllegalStateException to be thrown.

AFAIU, the intention of this test was to make sure that the cleaner logic is only called once even if the free method is called multiple times.

Issue Links

• is caused by: FLINK-21798 Guard MemorySegment against multiple frees.