[FLINK-30845] Params in jarURI end up in file name

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: kubernetes-operator-1.3.0
• Fix Version/s: kubernetes-operator-1.4.0
• Component/s: Kubernetes Operator
• Labels: pull-request-available starter
• Assignee: Fabio Wanner
• Reporter: Fabio Wanner
• Created: 31/Jan/23 07:55
• Updated: 07/Feb/23 11:29
• Resolved: 07/Feb/23 11:29

Description

Context

Jar files for jobs are submitted to the operator by supplying a URI to the .jar file. This URI can be a file system path or a URI to some HTTP resource. If a HTTP URI is given, the file will be fetched using the HttpArtifactFetcher. 

There are cases where the supplied URI will contain additional params. For example if pre-signed S3 URLs are used.

Example:

https://some-domain.example.com/some.jar?some=params

Problem

When the HttpArtifactFetcher determines the name of the .jar file it does also use the params as part of the file name. In the example from above the resulting file name would be:  some.jar?some=params

Submitting this job to Flink will result in an error as it will be checked for the file name to end with .jar

Possible Solution
In the HttpArtifactFetcher it would be enough to replace:

String fileName = FilenameUtils.getName(url.getFile());

with

String fileName = FilenameUtils.getName(url.getPath());

Issue Links

• links to: GitHub Pull Request #522