[FLINK-30489] flink-sql-connector-pulsar doesn't shade all dependencies

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.0
• Fix Version/s: pulsar-4.0.0
• Component/s: Connectors / Pulsar
• Labels: pull-request-available
• Assignee: Yufan Sheng
• Reporter: Henri Yandell
• Created: 22/Dec/22 21:19
• Updated: 13/Feb/23 13:42
• Resolved: 13/Feb/23 13:42

Description

Looking at https://repo1.maven.org/maven2/org/apache/flink/flink-sql-connector-pulsar/1.16.0/flink-sql-connector-pulsar-1.16.0.jar I'm seeing that some dependencies are shaded (com.fasterxml, com.yahoo etc), but others are not (org.sfl4j, org.bouncycastel, com.scurrilous, ...) and will presumably clash with other jar files.

Additionally, this bundling is going on in the '.jar' file rather than in a more clearly indicated separate -bundle or -shaded jar file.

As a jar file this seems confusing and potentially bug inducing; though I note I'm just a review of the jar and not Flink experienced.

Issue Links

• is blocked by: FLINK-30606 Bump Pulsar to 2.11.0
• links to: GitHub Pull Request #26