[FLINK-29340] ResourceManagerTest#testProcessResourceRequirementsWhenRecoveryFinished prone to race condition

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.16.0
• Fix Version/s: 1.17.0
• Component/s: Runtime / Coordination, Tests
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 19/Sep/22 19:24
• Updated: 22/Sep/22 23:23
• Resolved: 22/Sep/22 23:22

Description

The test incorrectly assumes that the declareRequiredResources has already been run when calling runInMainThread, while the RPC could still be in flight.
This can result in the test failing because within runInMainThread the test assumes that completing the readyToServeFuture will immediately result in the processing of resources, due to this workflow having been set up within delcareRequiredResources. Without it it will just fail because the completion of the future has in practice no effect.

Issue Links

• is caused by: FLINK-24713 Postpone resourceManager serving after the recovery phase has finished
• links to: GitHub Pull Request #20871