[FLINK-29253] DefaultJobmanagerRunnerRegistry#localCleanupAsync calls close instead of closeAsync

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.16.0, 1.17.0, 1.15.2
• Fix Version/s: 1.16.0, 1.17.0, 1.15.3
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Assignee: Matthias Pohl
• Reporter: Matthias Pohl
• Created: 12/Sep/22 06:26
• Updated: 13/Sep/22 07:12
• Resolved: 13/Sep/22 07:12

Description

DefaultJobmanagerRunnerRegistry#localCleanupAsync is meant to be called from the main thread. The current implementation calls close on the JobManagerRunner instead of closeAsync. This results in a blocking call on the Dispatcher's main thread which we want to avoid.

Thanks for identifying this issue, chesnay

Issue Links

• links to: BP 1.15 GitHub Pull Request #20813
• links to: BP 1.16 GitHub Pull Request #20812
• links to: GitHub Pull Request #20811