Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-28602

StateChangeFsUploader cannot close stream normally while enabling compression

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      While enabling compression, Changelog part will wrap output stream using   

      StreamCompressionDecorator#decorateWithCompression.

      As the comment said, "IMPORTANT: For streams returned by this method, {@link OutputStream#close()} is not propagated to the inner stream. The inner stream must be closed separately.".

      But StateChangeFsUploader will not close inner stream if wrapped stream has been closed.

      So the upload may not complete when enabling compression even if it returns success.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            masteryhx Hangxiang Yu
            masteryhx Hangxiang Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment