[FLINK-28322] DataStreamScanProvider's new method is not compatible

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.2
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: Jingsong Lee
• Reporter: Jingsong Lee
• Created: 30/Jun/22 08:27
• Updated: 01/Sep/22 11:11
• Resolved: 06/Jul/22 02:25

Description

In FLINK-25990 ,
Add a method "DataStream<RowData> produceDataStream(ProviderContext providerContext, StreamExecutionEnvironment execEnv)" in DataStreamScanProvider.
But this method has no default implementation, this is not compatible when users upgrade their DataStreamScanProvider implementation from 1.14 to 1.15. (The old method will not be called)
This method should be:

    default DataStream<RowData> produceDataStream(
            ProviderContext providerContext, StreamExecutionEnvironment execEnv) {
        return produceDataStream(execEnv);
    }

DataStreamSinkProvider is the same.

Impact on DataStreamSinkProvider:
DataStreamSinkProvider is no longer a functional interface and requires the use of an anonymous internal class.

Issue Links

• links to: GitHub Pull Request #20119