[FLINK-27800] addInEdge check state error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.17.0, 1.15.3, 1.16.1
• Fix Version/s: 1.17.0, 1.15.4, 1.16.2
• Component/s: API / Core
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Licho Sun
• Created: 26/May/22 10:14
• Updated: 16/Feb/23 08:06
• Resolved: 16/Feb/23 08:06

Description

when add InEdge, the checkState fucntion check the edge whether is in outEdges list, this should check whether in inEdges list.

 

public void addInEdge(StreamEdge inEdge) {
    checkState(
            outEdges.stream().noneMatch(inEdge::equals),
            "Adding not unique edge = %s to existing outEdges = %s",
            inEdge,
            inEdges);
    if (inEdge.getTargetId() != getId()) {
        throw new IllegalArgumentException("Destination id doesn't match the StreamNode id");
    } else {
        inEdges.add(inEdge);
    }
} 

Issue Links

• links to: GitHub Pull Request #19824