[FLINK-26174] KinesisDataStreamsSink.restoreWriter failed due to Architecture Violation

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: Connectors / Kinesis
• Labels: pull-request-available test-stability
• Assignee: Fabian Paul
• Reporter: Yun Gao
• Created: 16/Feb/22 06:38
• Updated: 16/Feb/22 10:48
• Resolved: 16/Feb/22 09:18

Description

Feb 15 19:28:44 [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 38.14 s <<< FAILURE! - in org.apache.flink.architecture.rules.ApiAnnotationRules
Feb 15 19:28:44 [ERROR] ApiAnnotationRules.PUBLIC_EVOLVING_API_METHODS_USE_ONLY_PUBLIC_EVOLVING_API_TYPES  Time elapsed: 0.391 s  <<< FAILURE!
Feb 15 19:28:44 java.lang.AssertionError: 
Feb 15 19:28:44 Architecture Violation [Priority: MEDIUM] - Rule 'Return and argument types of methods annotated with @PublicEvolving must be annotated with @Public(Evolving).' was violated (2 times):
Feb 15 19:28:44 org.apache.flink.connector.kinesis.sink.KinesisDataStreamsSink.restoreWriter(org.apache.flink.api.connector.sink2.Sink$InitContext, java.util.Collection): Argument leaf type org.apache.flink.kinesis.shaded.software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry does not satisfy: reside outside of package 'org.apache.flink..' or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated
Feb 15 19:28:44 org.apache.flink.connector.kinesis.sink.KinesisDataStreamsSink.restoreWriter(org.apache.flink.api.connector.sink2.Sink$InitContext, java.util.Collection): Returned leaf type org.apache.flink.kinesis.shaded.software.amazon.awssdk.services.kinesis.model.PutRecordsRequestEntry does not satisfy: reside outside of package 'org.apache.flink..' or annotated with @Public or annotated with @PublicEvolving or annotated with @Deprecated
Feb 15 19:28:44 	at com.tngtech.archunit.lang.ArchRule$Assertions.assertNoViolation(ArchRule.java:94)
Feb 15 19:28:44 	at com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:82)
Feb 15 19:28:44 	at com.tngtech.archunit.library.freeze.FreezingArchRule.check(FreezingArchRule.java:96)
Feb 15 19:28:44 	at com.tngtech.archunit.junit.ArchUnitTestDescriptor$ArchUnitRuleDescriptor.execute(ArchUnitTestDescriptor.java:159)
Feb 15 19:28:44 	at com.tngtech.archunit.junit.ArchUnitTestDescriptor$ArchUnitRuleDescriptor.execute(ArchUnitTestDescriptor.java:142)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Feb 15 19:28:44 	at java.util.ArrayList.forEach(ArrayList.java:1259)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Feb 15 19:28:44 	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Feb 15 19:28:44 	at java.util.ArrayList.forEach(ArrayList.java:1259)

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=31563&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=995c650b-6573-581c-9ce6-7ad4cc038461&l=27092

Issue Links

• is caused by: FLINK-25574 Update Async Sink to use decomposed interfaces
• relates to: FLINK-26186 update the API_ANNOTATIONS rule
• links to: GitHub Pull Request #18795