[FLINK-25952] Savepoint on S3 are not relocatable even if entropy injection is not enabled

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.13.5, 1.14.3, 1.15.0
• Fix Version/s: 1.14.4, 1.15.0, 1.13.7
• Component/s: FileSystems, Runtime / Checkpointing
• Labels: pull-request-available
• Assignee: Dawid Wysakowicz
• Reporter: Dawid Wysakowicz
• Created: 03/Feb/22 16:14
• Updated: 07/Feb/22 16:47
• Resolved: 07/Feb/22 16:47

Description

We have a limitation that if we create savepoints with an injected entropy, they are not relocatable (https://nightlies.apache.org/flink/flink-docs-master/docs/ops/state/savepoints/#triggering-savepoints).

However the check if we use the entropy is flawed. In FsCheckpointStreamFactory we check only if the used filesystem extends from EntropyInjectingFileSystem. FlinkS3FileSystem does, but it still may have the entropy disabled. FlinkS3FileSystem#getEntropyInjectionKey may still return null. We should check for that in org.apache.flink.core.fs.EntropyInjector#isEntropyInjecting

Issue Links

• links to: GitHub Pull Request #18630