[FLINK-25611] Remove CoordinatorExecutorThreadFactory thread creation guards

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.13.6, 1.14.4, 1.15.0
• Component/s: API / Core
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 11/Jan/22 11:55
• Updated: 18/Jan/22 09:09
• Resolved: 18/Jan/22 09:09

Description

The CoordinatorExecutorThreadFactory of the SourceCoordinator checks that only a single thread is active and that no new thread can be created if the previous one failed.

Neither of these guards work properly. If a runnable in the ThreadPoolExecutor fails then it actually uses the worker thread of the failed runnable to spawn a new worker. This means that at the time the second thread is created the previous thread is still alive, and the exception that caused the failure hasn't even been propagated to the threads exception handler.

As these guards do not work, and to boot result in the actual failure causes being hidden (like in FLINK-24855), we should remove them.

Issue Links

• links to: GitHub Pull Request #18329