[FLINK-24592] FlinkSQL multiline parser improvements

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: Table SQL / Client
• Labels: pull-request-available stale-assigned
• Assignee: Sergey Nuyanzin
• Reporter: Sergey Nuyanzin
• Created: 19/Oct/21 13:20
• Updated: 20/Jun/23 13:15
• Resolved: 20/Jun/23 13:15

Description

Currently existing multiline parser has limitations e.g.
line could not end with semicolon e.g. as a part of field value, comment or column name.
Also if a query contains '--' e.g. as a part of varchar field value then it fails.

In case there is no objections I would put some efforts to improve this behavior;

here it is a list of sample problem queries

select 123; -- comment

select 1 as `1--`;

select '--';

-- This query works if a user copy-pastes it to FlinkSQL, however it fails if a user types it in FlinkSQL
select '1;
';

Issue Links

• links to: GitHub Pull Request #17867