[FLINK-24507] Cleanup all the various date/time/timestamp utils - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.15.0
Component/s: None
Labels:
- pull-request-available

Description

There are different timestamp utils that won't be required anymore once ~~FLINK-21456~~ is solved. For example:

org.apache.flink.table.util.TimestampStringUtils
org.apache.flink.table.utils.TimestampStringUtils

Double check all the usages of these classes, and if there are any eventual classes like that, and replace them with the new DateTimeUtils in common whenever is possible.

Then double check the public methods of DateTimeUtils, eventually making some of them private. Some of these methods are used in the planner, where they should instead use the casting methods. Some of these methods should fail (e.g. the string to date parsing methods) while at the moment they don't.