[FLINK-24468] NPE when notifyNewBufferSize

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.3, 1.15.0
• Component/s: Runtime / Checkpointing
• Labels: pull-request-available
• Assignee: Anton Kalashnikov
• Reporter: Anton Kalashnikov
• Created: 07/Oct/21 09:24
• Updated: 15/Dec/21 01:44
• Resolved: 21/Oct/21 15:39

Description

In my opinion, we have two problem there:

1. The exception itself(see below)
2. Ignoring the exception and stopping rescheduling of the calculation of the buffer size.

Of course, we need to fix this NPE and we need to think what we want to do if the buffer debloat fails with error.

java.lang.NullPointerException: null
 at org.apache.flink.runtime.io.network.netty.CreditBasedPartitionRequestClientHandler.notifyNewBufferSize(CreditBasedPartitionRequestClientHandler.java:135) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.io.network.netty.NettyPartitionRequestClient.notifyNewBufferSize(NettyPartitionRequestClient.java:203) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.notifyNewBufferSize(RemoteInputChannel.java:330) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.io.network.partition.consumer.RemoteInputChannel.announceBufferSize(RemoteInputChannel.java:299) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.announceBufferSize(SingleInputGate.java:389) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.taskmanager.InputGateWithMetrics.announceBufferSize(InputGateWithMetrics.java:102) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.bufferdebloat.BufferDebloater.recalculateBufferSize(BufferDebloater.java:118) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.StreamTask.debloat(StreamTask.java:795) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.StreamTask.lambda$null$4(StreamTask.java:784) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.util.function.FunctionUtils.lambda$asCallable$5(FunctionUtils.java:126) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_282]
 at org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.runThrowing(StreamTaskActionExecutor.java:50) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.mailbox.Mail.run(Mail.java:90) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.processMailsNonBlocking(MailboxProcessor.java:353) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.processMail(MailboxProcessor.java:317) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:201) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:814) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:761) ~[flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:958) [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:937) [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:754) [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at org.apache.flink.runtime.taskmanager.Task.run(Task.java:575) [flink-dist_2.12-1.15-SNAPSHOT.jar:1.15-SNAPSHOT]
 at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282]

Issue Links

• Dependent: FLINK-23974 Decreased throughput with enabled buffer debloat
• links to: GitHub Pull Request #17440