[FLINK-2437] TypeExtractor.analyzePojo has some problems around the default constructor detection

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.0, 0.10.0
• Fix Version/s: 0.9.1, 0.10.0
• Component/s: API / Type Serialization System
• Assignee: Gabor Gevay
• Reporter: Gabor Gevay
• Created: 30/Jul/15 15:38
• Updated: 12/Aug/15 10:32
• Resolved: 12/Aug/15 10:31

Description

If a class does have a default constructor, but the user forgot to make it public, then TypeExtractor.analyzePojo still thinks everything is OK, so it creates a PojoTypeInfo. Then PojoSerializer.createInstance blows up.

Furthermore, a "return null" seems to be missing from the then case of the if after catching the NoSuchMethodException which would also cause a headache for PojoSerializer.

An additional minor issue is that the word "class" is printed twice in several places, because class.toString also prepends it to the class name.