[FLINK-2369] On Windows, in testFailingSortingDataSinkTask the temp file is not removed

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Runtime / Coordination

Environment

Windows 7 64-bit, JDK 8u51

• Assignee: Gábor Gévay
• Reporter: Gábor Gévay
• Created: 16/Jul/15 15:43
• Updated: 03/Mar/16 16:34
• Resolved: 03/Mar/16 16:34

Description

The test fails with the assert at the very end ("Temp output file has not been removed"). This happens because FileOutputFormat.tryCleanupOnError can't delete the file, because it is still open (note, that Linux happily deletes open files).

A fix would be to have the this.format.close(); not just in the finally block (in DataSinkTask.invoke), but also before the tryCleanupOnError call (around line 217).

Issue Links

• Is contained by: FLINK-3425 DataSinkTaskTest.Failing[Sorting]DataSinkTask fails on Windows