[FLINK-23383] FlinkEnvironmentContext#setUp is called twice

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: Benchmarks
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 14/Jul/21 12:46
• Updated: 14/Jul/21 16:42
• Resolved: 14/Jul/21 16:42

Description

Several benchmarks subclass the FlinkEnvironmentContext and override #setUp, like this:

@Setup
public void setUp() throws Exception {
    super.setUp();
    // do more stuff
}

Because this method is also annotated with @Setup, both the overridden and super version will be called separately, and since the overridden once also calls into super, then the super version is called twice.

This is not a problem right now, but it could result in leaks if we allocate a resource in super.setUp, because @TearDown would only be called once.

Issue Links

• links to: GitHub Pull Request #20