[FLINK-23030] PartitionRequestClientFactory#createPartitionRequestClient should throw when network failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0, 1.13.1, 1.12.4
• Fix Version/s: 1.14.0, 1.12.5, 1.13.2
• Component/s: Runtime / Network
• Labels: pull-request-available stale-blocker
• Assignee: Jin Xing
• Reporter: Jin Xing
• Created: 18/Jun/21 07:27
• Updated: 23/Sep/21 17:28
• Resolved: 21/Jun/21 15:14

Description

In current PartitionRequestClientFactory#createPartitionRequestClient, ChannelFuture#await() is invoked, thus to build a connection to remote synchronously.

But with the doc of io.netty.util.concurrent.Future [1] and its implementation io.netty.channel.DefaultChannelPromise [2], ChannelFuture#await() never throws when completed with failure. I guess what Flink needs is ChannelFuture#sync().

[1]  https://netty.io/4.1/api/io/netty/util/concurrent/class-use/Future.html

[2] https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelPromise.java

      https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java

Issue Links

• causes: FLINK-24133 PartitionRequestClientFactoryTest.testThrowsWhenNetworkFailure fails on Azure
• links to: GitHub Pull Request #16193
• links to: GitHub Pull Request #16193