Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-22725

SlotManagers should unregister metrics at the start of suspend()

Agile BoardRank to TopRank to BottomAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      Slotmanagers register metrics in start(), but only unregister them in close().

      This has 2 issues:

      a) If the SM is restarted it cannot re-register the metrics because the old ones are still present; this isn't a critical problem (because the old ones still work) but it produces unnecesasry logging noise

      b) The metric may produce an NPE when accessed by a reporter during suspend().

        Attachments

        Issue Links

          Activity

          $i18n.getText('security.level.explanation', $currentSelection) Viewable by All Users
          Cancel

            People

            • Assignee:
              chesnay Chesnay Schepler
              Reporter:
              chesnay Chesnay Schepler

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment