[FLINK-22367] syncSavepointId should only be reset if it is equal to the checkpoint id

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.13.0
• Fix Version/s: 1.13.3, 1.12.8
• Component/s: Runtime / Checkpointing
• Labels: auto-deprioritized-critical auto-unassigned pull-request-available test-stability
• Assignee: Anton Kalashnikov
• Reporter: Dawid Wysakowicz
• Created: 20/Apr/21 06:30
• Updated: 15/Dec/21 01:40
• Resolved: 03/Sep/21 15:00

Description

https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=16818&view=logs&j=2c3cbe13-dee0-5837-cf47-3053da9a8a78&t=2c7d57b9-7341-5a87-c9af-2cf7cc1a37dc&l=3844

[ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.135 s <<< FAILURE! - in org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase
Apr 19 22:28:44 [ERROR] terminateWithSavepointWithoutComplicationsShouldSucceedAndLeadJobToFinished(org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase)  Time elapsed: 10.237 s  <<< ERROR!
Apr 19 22:28:44 java.util.concurrent.ExecutionException: java.util.concurrent.TimeoutException: Invocation of public default java.util.concurrent.CompletableFuture org.apache.flink.runtime.webmonitor.RestfulGateway.stopWithSavepoint(org.apache.flink.api.common.JobID,java.lang.String,boolean,org.apache.flink.api.common.time.Time) timed out.
Apr 19 22:28:44 	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395)
Apr 19 22:28:44 	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999)
Apr 19 22:28:44 	at org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.stopWithSavepointNormalExecutionHelper(JobMasterStopWithSavepointITCase.java:123)
Apr 19 22:28:44 	at org.apache.flink.runtime.jobmaster.JobMasterStopWithSavepointITCase.terminateWithSavepointWithoutComplicationsShouldSucceedAndLeadJobToFinished(JobMasterStopWithSavepointITCase.java:111)
Apr 19 22:28:44 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Apr 19 22:28:44 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Apr 19 22:28:44 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Apr 19 22:28:44 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
Apr 19 22:28:44 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
Apr 19 22:28:44 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Apr 19 22:28:44 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
Apr 19 22:28:44 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Apr 19 22:28:44 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
Apr 19 22:28:44 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 19 22:28:44 	at org.apache.flink.util.TestNameProvider$1.evaluate(TestNameProvider.java:45)
Apr 19 22:28:44 	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
Apr 19 22:28:44 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
Apr 19 22:28:44 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
Apr 19 22:28:44 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
Apr 19 22:28:44 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 19 22:28:44 	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
Apr 19 22:28:44 	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
Apr 19 22:28:44 	at org.junit.runners.Suite.runChild(Suite.java:128)
Apr 19 22:28:44 	at org.junit.runners.Suite.runChild(Suite.java:27)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
Apr 19 22:28:44 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:55)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:137)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:107)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:83)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
Apr 19 22:28:44 	at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:158)
Apr 19 22:28:44 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
Apr 19 22:28:44 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
Apr 19 22:28:44 	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
Apr 19 22:28:44 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)

Issue Links

• links to: GitHub Pull Request #17055
• links to: GitHub Pull Request #17104