[FLINK-21696] scala code in "Writing WatermarkGenerators" documentation missing/deprecated

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.12.2, 1.13.0
• Fix Version/s: 1.13.0
• Component/s: Documentation
• Labels: pull-request-available
• Assignee: giackgamba
• Reporter: giackgamba
• Created: 09/Mar/21 23:37
• Updated: 12/Apr/21 10:33
• Resolved: 24/Mar/21 08:43

Description

Hi all,

I belive the scala code in the "Writing a Periodic WatermarkGenerator" and "Writing a Punctuated WatermarkGenerator" sections (Event Time -> Generating Watermark) is outdated/wrong.
And it's also missing in the previous section "Writing WatermarkGenerators".

It uses undefined arguments (output) – the onEvent and onPeriodicEmit methods have the wrong signatures.

If it's alright I can put up a PR with the scala code on how to extend WatermarkGenerator class and some comment.

Also sorry if I misplaced this Issue, feel free to improve/correct

Giack

Issue Links

• links to: GitHub Pull Request #15309